search

opensearch-project / opensearch-oci-object-storage

OpenSearch Repository Plugin For Oci Object Storage
Apache License 2.0
7 stars 19 forks source link

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #28

Closed dblock closed 1 year ago

dblock commented 1 year ago

Follow https://github.com/opensearch-project/.github/issues/125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

dblock commented 1 year ago

Permissions are incorrect. You have 28+ people with admin access. Please work with admin to fix.

Screenshot 2023-03-23 at 10 59 10 AM

anasalkouz commented 1 year ago

@samuel-oci, could you please revoke admin access from clients group?

samuel-oci commented 1 year ago

Hi @anasalkouz , I don't think I have the capability to do so at the moment, perhaps I need to be able another permission to see all other admins?

image
anasalkouz commented 1 year ago

@dblock Could you please help on this? neither I nor @samuel-oci has access.

dblock commented 1 year ago

@bbarani I don't have access either, help?

bbarani commented 1 year ago

I am not seeing the setting tab to view the current list of maintainers as well. @samuel-oci can you try to add the team @opensearch-project/admin team as admin user? I will reach out to the OpenSearch repository orgnaization owners if you are not able to do it.

wbeckler commented 1 year ago

@CEHENKLE @hyandell Can one of you change the @opensearch-project/admin team hear to Admin access rather than Read access, as appears in DB's screenshot above. I think this requires repo-level admin privileges as nobody has admin in this repo.

hyandell commented 1 year ago

@admin changed to have Admin perms.

wbeckler commented 1 year ago

I added the named maintainers as maintainers in the guithub permssions. @samuel-oci can you take a look and confirm the changes are okay?

peternied commented 1 year ago

Screenshot: image

samuel-oci commented 1 year ago

Hi William,Unfortunately I have out of town with not much internet access until 04/17, can check when I’m back.Thanks,SamSent from my iPhoneOn Apr 7, 2023, at 6:51 PM, William Beckler @.***> wrote: I added the named maintainers as maintainers in the guithub permssions. @samuel-oci can you take a look and confirm the changes are okay?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

anasalkouz commented 1 year ago

@peternied changes looks good to me.

anasalkouz commented 1 year ago

I think we can resolve the issue now.

dblock commented 1 year ago

Thanks, verified.