Check if root cause exists in $error['error']

opensearch-project / opensearch-php

Official PHP Client for OpenSearch

Other

109 stars 58 forks source link

Check if root cause exists in $error['error'] #104

Closed wblessen closed 7 months ago

wblessen commented 2 years ago

Description

Opensearch failed with missing array key root_cause in Connection.php

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

wblessen commented 2 years ago

Could you add a small unit test?

@shyim

Yes, I can try.

Do you have a draft and a suggestion, which folder to use?

shyim commented 1 year ago

Hey @wblessen ,

sorry for the late response.

You can add the test case to the existing file: https://github.com/opensearch-project/opensearch-php/blob/main/tests/Connections/ConnectionTest.php

Also don't forget to sign your commits with --signoff to pass the DCO check. Let me know if I can help you! 💙

bbarani commented 1 year ago

Anyone looking in to this PR? @shyim @wblessen

drunken-monkey commented 1 year ago

I created my own PR #168 for this, since there doesn’t seem to be any movement on this one.

dblock commented 7 months ago

Merged via https://github.com/opensearch-project/opensearch-php/pull/168.