Closed harrowmykel closed 2 years ago
This is awesome! Thank you! Just for the reviewers' sakes, I noticed that some of this is verbatim from an API spec here: https://github.com/elastic/elasticsearch/blob/c5930851043522c69613f68b2ac3b8ac3dfbcfbe/rest-api-spec/src/main/resources/rest-api-spec/api/search.json#L162-L165
The above spec is Apache License v2.0, and therefore a contribution based on it is compatible with its license.
So, it doesn't look like a licensing issue.
Thanks! Please fix DCO (needs git commit -s).
:exclamation: No coverage uploaded for pull request base (
main@cf91bd8
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage ? 26.96%
Complexity ? 1934
=======================================
Files ? 245
Lines ? 5544
Branches ? 0
=======================================
Hits ? 1495
Misses ? 4049
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Ok. i have done that
As well here you have to signoff all your commits
Description
search(array $params = []) function does not show the following. so I added it
Issues Resolved
101