search

opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
110 stars 58 forks source link

[FEATURE] Remove includePortInHostHeader #122

Open dblock opened 1 year ago

dblock commented 1 year ago

Is your feature request related to a problem?

The library has a client builder option includePortInHostHeader. This seems unnecessary. Why do we need an option at all? Can we replace it with the solution below of automatically including the port number unless it's a default port?

What solution would you like?

A port should always be included if it's not the default one (HTTP = 80, HTTPS = 443).

Do you have any additional context?

Coming from https://github.com/opensearch-project/opensearch-php/pull/118

saimedhi commented 6 months ago

Hello @joanna-bak-sourceability, I hope you're doing well. If you have a moment to spare, would you be open to considering taking up this issue? Thank you.