opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
110 stars 58 forks source link

fix: remove elasticsearch x-pack apis #139

Closed shyim closed 1 year ago

shyim commented 1 year ago

Description

Remove x-pack related apis

Issues Resolved

Fixes #137

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov-commenter commented 1 year ago

Codecov Report

Merging #139 (6ed274f) into main (87f41a8) will increase coverage by 0.14%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #139      +/-   ##
============================================
+ Coverage     23.91%   24.06%   +0.14%     
+ Complexity     1935     1924      -11     
============================================
  Files           245      243       -2     
  Lines          6848     6807      -41     
============================================
  Hits           1638     1638              
+ Misses         5210     5169      -41     
Impacted Files Coverage Δ
src/OpenSearch/Client.php 21.96% <ø> (+0.75%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dblock commented 1 year ago

@shyim your DCO is Signed-off-by: GitHub <noreply@github.com>, you should probably fix that.

shyim commented 1 year ago

I was lazy and used codespaces 😅

pwnb0t commented 1 year ago

Hey, I believe PIT is supported in OpenSearch: https://opensearch.org/docs/latest/search-plugins/point-in-time-api/

I ran a test with OpenSearch 2.5.0 and modified this line: https://github.com/opensearch-project/opensearch-php/pull/139/files#diff-cdef139ac055ca2db8ceb1529e5d0e91351a96909eee68dec4994ca1e71c13bcL33

from

return "/$index/_pit";

to:

return "/$index/_search/point_in_time";

as a quick test and it worked, yielding a result like:

Array
(
    [pit_id] => s5D9QAEZc3VibWlzc2lvbnMtdjAwMDEtaW5kZXgtMRZybjd0ajdlbVNlT3ctUkp1cXBRbV9BABZVLTBNSEQxX1JhU2ZRLWJyZW9nRGxBAAAAAAAAAAAKFkVqdjd0T1dXU002aVNjRklmQ1FYNlEBFnJuN3RqN2VtU2VPdy1SSnVxcFFtX0EAAA==
    [_shards] => Array
        (
            [total] => 1
            [successful] => 1
            [skipped] => 0
            [failed] => 0
        )

    [creation_time] => 1680039902345
)
shyim commented 1 year ago

I created a issue to readd it with all the API's https://github.com/opensearch-project/opensearch-php/issues/141