opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
109 stars 58 forks source link

Adds newer OpenSearch builds to integration tests and updates unreleased to use new caching mechanism #143

Closed harshavamsi closed 7 months ago

harshavamsi commented 1 year ago

Description

Adds newer OpenSearch builds to integration tests and updates unreleased to use new caching mechanism

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov-commenter commented 1 year ago

Codecov Report

Merging #143 (e1f426f) into main (967eb3f) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main     #143   +/-   ##
=========================================
  Coverage     24.05%   24.05%           
  Complexity     1921     1921           
=========================================
  Files           243      243           
  Lines          6804     6804           
=========================================
  Hits           1637     1637           
  Misses         5167     5167           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dblock commented 1 year ago

Care to look at test failures?

shyim commented 1 year ago

Is there a config missing? Never saw before cluster_manager_not_discovered_exception

harshavamsi commented 1 year ago

Is there a config missing? Never saw before cluster_manager_not_discovered_exception

Yeah I don't understand what is going on. Looks like it is not able to discover the cluster, but the cluster is running in a previous step -- https://github.com/opensearch-project/opensearch-php/actions/runs/4577473959/jobs/8082928712#step:8:57

VachaShah commented 1 year ago

@harshavamsi Want to finish this?

dblock commented 7 months ago

Finishing this in https://github.com/opensearch-project/opensearch-php/pull/180.