opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
99 stars 56 forks source link

Fixed bug in ClientBuilder where basic authentication is overridden by connection params #160

Closed CSalih closed 1 year ago

CSalih commented 1 year ago

Description

This fixes a bug in ClientBuilder where basic authentication is overridden when first basic authentication then connection params is set.

Issues Resolved

Fixes #159

codecov[bot] commented 1 year ago

Codecov Report

Merging #160 (ee9c261) into main (8b6cdbc) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #160      +/-   ##
============================================
+ Coverage     24.14%   24.16%   +0.02%     
- Complexity     1937     1938       +1     
============================================
  Files           246      246              
  Lines          6863     6865       +2     
============================================
+ Hits           1657     1659       +2     
  Misses         5206     5206              
Impacted Files Coverage Δ
src/OpenSearch/ClientBuilder.php 74.42% <100.00%> (+0.19%) :arrow_up:
shyim commented 1 year ago

Thanks for your work on this! :)