opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
109 stars 58 forks source link

Added support for `format` parameter to specify the sql response format #161

Closed CSalih closed 1 year ago

CSalih commented 1 year ago

Description

NOTE PR is a cherry pick of the contribution from PR #156 and adds test to complete it. Credits goes to @archipelweb

This PR will add support to specify the response format of the SQL endpoint.

Issues Resolved

Issue: #155 PR: #156

codecov[bot] commented 1 year ago

Codecov Report

Merging #161 (75f2943) into main (8b6cdbc) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #161      +/-   ##
============================================
+ Coverage     24.14%   24.17%   +0.02%     
  Complexity     1937     1937              
============================================
  Files           246      246              
  Lines          6863     6863              
============================================
+ Hits           1657     1659       +2     
+ Misses         5206     5204       -2     
Impacted Files Coverage Δ
src/OpenSearch/Namespaces/SqlNamespace.php 100.00% <ø> (ø)
src/OpenSearch/Endpoints/Sql/Query.php 100.00% <100.00%> (+33.33%) :arrow_up:
CSalih commented 1 year ago

Sure why not @VachaShah. Just two questions: Should I extend the example usage or do you want something in particular? And do you want it in a new PR or in this one?

dblock commented 1 year ago

Add to this PR @CSalih. Sample usage is enough, whatever you want to write that could be helpful to a user. And much thanks!