opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
110 stars 58 forks source link

Fix warning in Connection::tryDeserializeError() #168

Closed drunken-monkey closed 8 months ago

drunken-monkey commented 1 year ago

Description

Fixes code in \OpenSearch\Connections\Connection::tryDeserializeError() to properly check whether $error['error']['root_cause'] exists before accessing it.

Issues Resolved

Closes #167.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dblock commented 1 year ago

@drunken-monkey Your second commit is missing DCO, please?

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9ebb183) 24.19% compared to head (cc67d75) 24.19%.

:exclamation: Current head cc67d75 differs from pull request most recent head dbd796f. Consider uploading reports for the commit dbd796f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #168 +/- ## ============================================ - Coverage 24.19% 24.19% -0.01% + Complexity 1938 1936 -2 ============================================ Files 246 246 Lines 6865 6862 -3 ============================================ - Hits 1661 1660 -1 + Misses 5204 5202 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drunken-monkey commented 1 year ago

@drunken-monkey Your second commit is missing DCO, please?

Sorry, fixed!

dblock commented 1 year ago

Do add a line to CHANGELOG. This fixes a bug.

dblock commented 1 year ago

@drunken-monkey You have to amend your last commit to pass DCO, please?

j-fulbright commented 8 months ago

Can this get brought in? It is causing headaches with AWS OSS

dblock commented 8 months ago

Need another maintainer to approve. @VachaShah @shyim @harshavamsi ?