opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
91 stars 54 forks source link

added highlight to search endpoint whitelist #171

Open prattcmp opened 7 months ago

prattcmp commented 7 months ago

Description

It fixes the whitelist for the search endpoint by adding "highlight". Maintainers should highly consider removing whitelist or making it optional.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9ebb183) 24.19% compared to head (8054d23) 24.19%.

Files Patch % Lines
src/OpenSearch/Endpoints/Search.php 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #171 +/- ## ============================================ - Coverage 24.19% 24.19% -0.01% Complexity 1938 1938 ============================================ Files 246 246 Lines 6865 6866 +1 ============================================ Hits 1661 1661 - Misses 5204 5205 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dblock commented 2 months ago

@prattcmp Want to finish this?