opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
109 stars 58 forks source link

Updated opensearch-php to reflect the latest OpenSearch API spec #223

Closed opensearch-trigger-bot[bot] closed 1 month ago

opensearch-trigger-bot[bot] commented 3 months ago

Updated opensearch-php to reflect the latest OpenSearch API spec Date: 2024-10-25

dblock commented 3 months ago

I don't merge all of these to gather more of the API changes together, then merge all at once before a release.

dblock commented 2 months ago

Some legit errors that need to be looked at from the generated code.

1) OpenSearch\Tests\Namespaces\MlNamespaceTest::testDeployModel
OpenSearch\Common\Exceptions\RuntimeException: Missing parameter for the endpoint ml.deploy_model

/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Endpoints/Ml/DeployModel.php:32
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/AbstractNamespace.php:63
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/MlNamespace.php:273
/Users/runner/work/opensearch-php/opensearch-php/tests/Namespaces/MachineLearningNamespaceTest.php:[32](https://github.com/opensearch-project/opensearch-php/actions/runs/10571259471/job/29287037384?pr=223#step:5:33)6

2) OpenSearch\Tests\Namespaces\MlNamespaceTest::testUnDeployModel
OpenSearch\Common\Exceptions\RuntimeException: Missing parameter for the endpoint ml.undeploy_model

/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Endpoints/Ml/UndeployModel.php:32
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/AbstractNamespace.php:63
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/MlNamespace.php:420
/Users/runner/work/opensearch-php/opensearch-php/tests/Namespaces/MachineLearningNamespaceTest.php:[34](https://github.com/opensearch-project/opensearch-php/actions/runs/10571259471/job/29287037384?pr=223#step:5:35)6
dblock commented 1 month ago

The ML namespace changed parameter names, fixed the templates.