Run unit tests with PHP 8.3 and 8.4 on CI

opensearch-project / opensearch-php

Official PHP Client for OpenSearch

Other

109 stars 58 forks source link

Run unit tests with PHP 8.3 and 8.4 on CI #229

Closed TimWolla closed 1 month ago

TimWolla commented 1 month ago

Description

This PR runs composer run unit with PHP 8.3 and 8.4 in CI. Previously only PHP 7.3 - 8.2 were tested.

Issues Resolved

n/a

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

TimWolla commented 1 month ago

You might also want to consider upgrading the jobs using PHP 8.2 to 8.3.

dblock commented 1 month ago

You might also want to consider upgrading the jobs using PHP 8.2 to 8.3.

Yes, please do!

TimWolla commented 1 month ago

Would you mind taking a look at integration tests? I think it needs something similar to https://github.com/opensearch-project/opensearch-sdk-py/pull/195/files.

Done in #231. I believe it would need approval either way, because I'm touching the action definition, so I might as well do it cleanly in a separate PR.

dblock commented 1 month ago

Rebase on top of https://github.com/opensearch-project/opensearch-php/pull/231?

shyim commented 1 month ago

thanks!