opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
109 stars 58 forks source link

Fix: build OpenSearch with the correct Java/Gradle combination. #234

Closed dblock closed 1 month ago

dblock commented 1 month ago

Description

Fixes CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

shyim commented 1 month ago

Maybe we should make a composite action inside Opensearch org, so all use the same configuration 🤔

dblock commented 1 month ago

Maybe we should make a composite action inside Opensearch org, so all use the same configuration 🤔

Yes, it's a good idea, open an issue in https://github.com/opensearch-project/opensearch-clients? I'll finish fixing this one though here just to get us unblocked.

dblock commented 1 month ago

@shyim this is ready to review/merge

shyim commented 1 month ago

Thanks for your time! ❤️