search

opensearch-project / opensearch-php

Official PHP Client for OpenSearch
Other
109 stars 58 forks source link

Require minimum PHP 8.0 #239

Closed kimpepper closed 1 week ago

kimpepper commented 2 weeks ago

Description

PHP 7.4 was EOL 2 years ago (Nov 2022). We want to use modern PHP features such as static return types. This requires PHP 8.0+

Issues Resolved

Fixes build failure in #238

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dblock commented 2 weeks ago

Good with me. Add to CHANGELOG ("Removed support for PHP 7.x.").

Generally this is considered a breaking change, we tend to do those if there's a real reason to do it (e.g. unnecessarily difficult to maintain, etc.). Static types is a good reason.