search

opensearch-project / opensearch-plugins

For all things OpenSearch plugins. You want to install, or develop a plugin? You've come to the right place.
Apache License 2.0
49 stars 61 forks source link

Publish plugin zips to maven repo #145

Closed prudhvigodithi closed 2 years ago

prudhvigodithi commented 2 years ago

Description

With existing setup the plugin jars are only published to maven repo, but not the generated plugin zips.

Related META issue

https://github.com/opensearch-project/opensearch-build/issues/1916

Current Behavior

Existing all maven publications target the jar files to publish to maven, but not the generated distribution zips.

Expected Behavior

Along with plugin jars, plugin zips should also be published to maven repo with right maven coordinates, so user can download these plugins using dependancy model.

Steps To Reproduce

  1. Run the gradle assemble task that outputs jar and zips.
  2. Using build setup the jars are published to local staging maven repo.
  3. Zip's are just added to distribution's folder during build runtime.
  4. Finally once build is done, just the jar files are added to local maven repo and updates to the manifest file, but not the zips.

Proposed solution

A custom gradle plugin solution that can create the publication task for the zips to get published to local staging maven repo with right maven coordinates. Add/Configure the custom gradle plugin openseearch.pluginzip to the gradle project and test the generated plugin zip's to upload to local maven repo. More details on how to use the Plugin: https://github.com/prudhvigodithi/opensearch-plugins/blob/main/GRADLE_CUSTOM_PLUGINS.md PR

prudhvigodithi commented 2 years ago

Closing this issue as this feature (publishing plugin zips to maven repo)is not required for this repo.