search

opensearch-project / opensearch-plugins

For all things OpenSearch plugins. You want to install, or develop a plugin? You've come to the right place.
Apache License 2.0
51 stars 61 forks source link

Update the document BUILDING.md: opensearch.opensearchplugin add groupID field to org.opensearch.plugin #162

Closed prudhvigodithi closed 2 years ago

prudhvigodithi commented 2 years ago

Description

Update the document BUILDING.md The configuration modification for the gradle plugin opensearch.opensearchplugin to make sure the groupId is added as org.opensearch.plugin to the publication pluginZip inside the build.gradle file.

Related META issue

Part of: https://github.com/opensearch-project/opensearch-build/issues/2521 From solution: https://github.com/opensearch-project/OpenSearch/issues/3692

Current Behavior

The opensearch.opensearchplugin uses the default setting for groupId as org.opensearch.plugin, this when extended with open source community, it should be feasible to ammend the groupId as per required, hence for opensearch plugins the groupId should be mentioned as org.opensearch.plugin to make sure the opensearch plugins are published to this groupID and for other generic uses this can be extended to the custom groupId.

Expected Behavior

Once the groupId is added as org.opensearch.plugin to the publication pluginZip inside the build.gradle file, the plugin zips should continue to be published to the existing groupID.

Proposed solution

Solution from the PR: https://github.com/opensearch-project/OpenSearch/issues/3692

prudhvigodithi commented 2 years ago

Hey @lukas-vlcek when you get a chance can you please update the document with the latest changes from your PR? Thank you @dblock @bbarani @reta

lukas-vlcek commented 2 years ago

@prudhvigodithi Please see https://github.com/opensearch-project/opensearch-plugins/pull/175

prudhvigodithi commented 2 years ago

Thanks @lukas-vlcek closing this issue and related PR is merged https://github.com/opensearch-project/opensearch-plugins/pull/175.