search

opensearch-project / opensearch-plugins

For all things OpenSearch plugins. You want to install, or develop a plugin? You've come to the right place.
Apache License 2.0
51 stars 61 forks source link

[META] Backport Windows Support for 1.x #181

Open rishabh6788 opened 1 year ago

rishabh6788 commented 1 year ago

Is your feature request related to a problem?

Coming from https://github.com/opensearch-project/opensearch-build/issues/33. In order to support a Windows x64 distribution for OpenSearch 1.x each plugin needs to backport Windows CI to their 1.x branch and include tools that are windows-specific as replacements for any bash scripts.

What solution would you like?

Every component has passing CI on Windows (windows-latest on GHA), including unit, integration and bcw tests for 1.x branch, and has Windows-specific documentation, if needed.

OpenSearch

Dashboards

peternied commented 1 year ago

@rishabh6788 Can you provide the background on why we want to do this work?

Its a considerable investment for the Security plugin since its build infrastructure was rewritten for OpenSearch 2.X and I would rather focus on supporting existing platforms and new features going forward.

CEHENKLE commented 1 year ago

@rishabh6788 Can you provide the background on why we want to do this work?

As a general principal, when we provide support for a distribution, we provide it for all or the releases we support. Since we currently support 1.x and 2.x, it means they both need to have windows distributions.

If we don't do it this way, it means that we need to maintain a matrix somewhere for customer to go figure out what's supported where, which I think is a suboptimal experience.

peternied commented 1 year ago

we need to maintain a matrix somewhere for customer to go figure out what's supported where

We already do this on the downloads page [1] by pushing customers to follow a link for 1.x releases.

Are there customers interested in running 1.3 version of OpenSearch on Windows and are not interested in running 2.4? It would be a much easier for me to understand if we had a ready and waiting audience as opposed to an ideal.

image

[1] From https://opensearch.org/downloads.html

dblock commented 1 year ago

I am surprised we want Windows support in 1.x. It's a new platform, so what kind of user would want to start on an already legacy version of OpenSearch that is only receiving security fixes?

CEHENKLE commented 1 year ago

@dblock @peternied Barani's out, but my understanding is that we have customers who have wanted windows for the last year+, but we didn't offer it so they've made do (or rolled their own). Ideally, we would have launched 1.0 with Windows. We didn't so now we're playing catch up.

peternied commented 1 year ago

Recapping from offline - the Security team is all in to support Windows. I've updated the issues associated with security/security-dashboard-plugins.