search

opensearch-project / opensearch-plugins

For all things OpenSearch plugins. You want to install, or develop a plugin? You've come to the right place.
Apache License 2.0
49 stars 61 forks source link

Add MacOS (Darwin) Support #96

Open dblock opened 2 years ago

dblock commented 2 years ago

Is your feature request related to a problem?

Coming from https://github.com/opensearch-project/opensearch-build/issues/38. In order to release a MacOS distribution each plugin needs to work on MacOS.

What solution would you like?

Every component has passing CI on MacOS (macos-latest on GHA) and has MacOS-specific documentation, if needed.

ylwu-amzn commented 2 years ago

Should we finish this in 1.2 release?

dblock commented 2 years ago

Should we finish this in 1.2 release?

It's in the roadmap under 1.3 currently, but don't wait on other plugins to add MacOS CI :)

dbbaughe commented 2 years ago

@dblock I'm assuming plugins are blocked from moving forward on this until core publishes the min mac distribution?

dblock commented 2 years ago

@dblock I'm assuming plugins are blocked from moving forward on this until core publishes the min mac distribution?

Plugins should be able to build and CI on MacOS without core. Maven dependencies aren't platform-specific.

dbbaughe commented 2 years ago

@dblock I'm assuming plugins are blocked from moving forward on this until core publishes the min mac distribution?

Plugins should be able to build and CI on MacOS without core. Maven dependencies aren't platform-specific.

Wouldn't that mean macos development is solved then and all plugin developers should be able to develop on their local macos? Has that been fixed? I know we have a hacky workaround to switch from ARCHIVE to INTEG_TEST for the distribution, but that does not include any of the extra modules which means a lot of plugin functionality is broken.

dblock commented 2 years ago

@dblock I'm assuming plugins are blocked from moving forward on this until core publishes the min mac distribution?

Plugins should be able to build and CI on MacOS without core. Maven dependencies aren't platform-specific.

Wouldn't that mean macos development is solved then and all plugin developers should be able to develop on their local macos? Has that been fixed? I know we have a hacky workaround to switch from ARCHIVE to INTEG_TEST for the distribution, but that does not include any of the extra modules which means a lot of plugin functionality is broken.

Yes, that too. I don't know anything about ARCHIVE vs. INTEG_TEST, point to an issue? We should fix it.

derek-ho commented 2 months ago

@dblock is this still planned, or should we close this out?

dblock commented 2 months ago

This is still valid.