Open thanawan-atc opened 1 year ago
@thanawan-atc should we not go to 2.0.3 since it's the latest in that line?
Also, do you think we should change the requirements.txt to be <2.0 as 2.1 is currently broken and is not getting added to testing?
I believe 2.0.3 also made the integration test failed as well. Our plan is to update pandas-related functions that were deprecated and then bump pandas from 1.5.0 to 2.x.
@Yerzhaisang you can pick up this task. Please let me know if you have any question regarding this.
got it
Can I work on this issue?
Can I work on this issue?
If I can't resolve this issue on this weekend, you can take it
May I try on this issue?
Sure, assigning it to you.
The upgrade to 2.x should also resolve #263
Dear @dhrubo-os , can you please update this issue card?
If this issue is still actual and there is no updates, reassign it to me please
Hey @Yerzhaisang any updates? I see you created a PR last month and I can confirm it works (I ran pip install git+https://github.com/Yerzhaisang/opensearch-py-ml.git@dev
) so what needs to happen in order to get this merged in?
@soapergem Thank you for the comment.
Dear @dhrubo-os, can I start fix from scratch and raise another PR. If yes, I will close https://github.com/opensearch-project/opensearch-py-ml/pull/366 and raise another PR. Thank you!
Sure, go ahead.
@Yerzhaisang are you still working on this issue?
@Yerzhaisang are you still working on this issue?
Dear @dhrubo-os , please, just follow the commits on this branch
Already did:
Replaced mad
method with custom one.
Started replacing _construct_axes_from_arguments
method with custom one.
To bump pandas version from 1.5.0 to 2.x, we have to make changes to resolve issues such as
AttributeError: 'DataFrameGroupBy' object has no attribute 'mad'
-> mad() is deprecated after 1.5.0 (https://pandas.pydata.org/pandas-docs/version/1.5/reference/api/pandas.DataFrame.mad.html)(https://github.com/pandas-dev/pandas/issues/11787)AttributeError("'DataFrame' object has no attribute '_construct_axes_from_arguments'"
TypeError: quantile() got an unexpected keyword argument 'numeric_only'
TypeError: to_csv() got an unexpected keyword argument 'line_terminator'
To see the full error on GitHub Actions,
export PANDAS_VERSION=${PANDAS_VERSION-2.0.1}
@nox.parametrize("pandas_version", ["2.0.1"])
Note that we can bump it to be 2.0.3 or above as well.Actions
tab > ClickIntegration tests
on the right menu > Choose the test that is running on the branch with your changesSee example of GitHub Actions log here: https://github.com/thanawan-atc/opensearch-py-ml/actions/runs/6040143974/job/16390355081
We have to change those deprecated functions so that it works with pandas 2.x.
Once there is no error in integration test, we can then update
requirements.txt
,requirements-dev.txt
,requirements-docs.txt
, ci file, and noxfile to use new pandas version.Lastly, make sure that the integration workflow and build-deploy-doc workflow do not fail with the new pandas version.