Closed lattwood closed 1 year ago
Merging #470 (32074ec) into main (8485606) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 70.91% 70.92%
=======================================
Files 81 81
Lines 7730 7732 +2
=======================================
+ Hits 5482 5484 +2
Misses 2248 2248
Files Changed | Coverage Δ | |
---|---|---|
opensearchpy/helpers/asyncsigner.py | 95.83% <100.00%> (+0.18%) |
:arrow_up: |
opensearchpy/helpers/signer.py | 94.73% <100.00%> (+0.14%) |
:arrow_up: |
@dblock unless you can think of a better solution to Mock
being overeager around the get_frozen_credentials
method (that I'd be happy to implement), I'd say go ahead and merge it. Anything I need to do for backports?
Figured it out, another commit will be forthcoming
doing one more force push to retrigger that failing integration test
doing one more force push to retrigger that failing integration test
This failure has been so annoying. Hope someone can make the test more reliable. Wink wink.
doing one more force push to retrigger that failing integration test
This failure has been so annoying. Hope someone can make the test more reliable. Wink wink.
Looks like it's related to docker networking stuff 😅
Anything I need to do for backports?
AFAIK no, we release from main, @VachaShah yes?
Anything I need to do for backports?
AFAIK no, we release from main, @VachaShah yes?
was why I asked (CONTRIBUTING.md)
Good work @lattwood ! Also great GitHub profile blurb. You're talking to an LLM btw here ;)
Anything I need to do for backports?
AFAIK no, we release from main, @VachaShah yes?
Yeah no backports are required currently as we release from main since there have been no breaking changes in this client, so main = 2.x.
The backport to 2.3
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-470-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fca8bd3d0e7f42f2458e924c36ac6a135a6bc622
# Push it to GitHub
git push --set-upstream origin backport/backport-470-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3
Then, create a pull request where the base
branch is 2.3
and the compare
/head
branch is backport/backport-470-to-2.3
.
Closes #423