opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
350 stars 175 forks source link

Backport- Fixed race condition in AWSV4SignerAuth & AWSV4SignerAsyncAuth when using refreshable credentials #473

Closed saimedhi closed 1 year ago

saimedhi commented 1 year ago

Description

Backport #470 to 2.3. Fixed race condition in AWSV4SignerAuth & AWSV4SignerAsyncAuth when using refreshable credentials

Issues Resolved

Related to #472

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #473 (6da9190) into 2.3 (f108677) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              2.3     #473   +/-   ##
=======================================
  Coverage   70.91%   70.92%           
=======================================
  Files          81       81           
  Lines        7730     7732    +2     
=======================================
+ Hits         5482     5484    +2     
  Misses       2248     2248           
Files Changed Coverage Δ
opensearchpy/helpers/asyncsigner.py 95.83% <100.00%> (+0.18%) :arrow_up:
opensearchpy/helpers/signer.py 94.73% <100.00%> (+0.14%) :arrow_up:
saimedhi commented 1 year ago

Sorry, I missed DCO. I hope it won't create any problem. Can I release this patch version?

dblock commented 1 year ago

I force-pushed a DCO fix to 2.3.

Let's go a little slower and not merge things on red.