search

opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
338 stars 170 forks source link

Revised Security Client APIs to achieve consistency with other clients #483

Closed saimedhi closed 10 months ago

saimedhi commented 1 year ago

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #483 (a3639fa) into main (c8b04a5) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files          81       81           
  Lines        7732     7732           
=======================================
  Hits         5484     5484           
  Misses       2248     2248
Files Changed Coverage Δ
opensearchpy/_async/client/security.py 43.72% <100.00%> (ø)
opensearchpy/client/security.py 43.72% <100.00%> (ø)
saimedhi commented 1 year ago

To achieve consistency with cat client, Renamed "health_check" API to "health". To achieve consistency with other language clients and also other similar APIs, Renamed "update_audit_config" API to "update_audit_configuration".

dblock commented 10 months ago

Is this still needed with client code generation?