opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
350 stars 175 forks source link

Guide/snapshots #490

Closed tejaksha closed 12 months ago

tejaksha commented 1 year ago

Description

Added the code snippets for snapshots using python client

Issues Resolved

This will resolve the issue #406

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #490 (6befbde) into main (c8b04a5) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files          81       81           
  Lines        7732     7732           
=======================================
  Hits         5484     5484           
  Misses       2248     2248           
dblock commented 1 year ago

Also I'm seeing https://github.com/opensearch-project/opensearch-py/pull/486 which may be further along.

saimedhi commented 1 year ago

Hello @tejaksha,

We appreciate your work on this PR (#490). However, it appears that both PRs (#490 and #486) are addressing snapshot guides. To ensure efficiency and avoid redundancy, we recommend consolidating your contributions into PR #486. Collaborating with @roma2023 can help expedite progress. Please consider closing this PR and following this approach.

Thank you for your understanding and cooperation.

dblock commented 12 months ago

Looks like https://github.com/opensearch-project/opensearch-py/pull/486 is a lot further along, I'm going to close this. Please feel free to finish either.