opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
359 stars 179 forks source link

[CCI][GUIDE] Minor fixes to poetry docs #494

Closed roma2023 closed 1 year ago

roma2023 commented 1 year ago

Description

Added python to run command of poetry. Now it runs as poetry run python hello/hello.py .

Issues Resolved

Issue #493 resolved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #494 (dcea653) into main (c8b04a5) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files          81       81           
  Lines        7732     7732           
=======================================
  Hits         5484     5484           
  Misses       2248     2248           
saimedhi commented 1 year ago

@roma2023, Issue is not specific to windows. I experienced it in Mac when running security/roles or security/users samples.

roma2023 commented 1 year ago

@saimedhi Then, I believe the issue was more about the run command rather than the machine it was being run.

saimedhi commented 1 year ago

Change it to ready for review after you are done updating. Thank you :)