opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
350 stars 175 forks source link

Integrated generated 'nodes' client APIs into the existing module #514

Closed saimedhi closed 1 year ago

saimedhi commented 1 year ago

Description

Integrated generated 'nodes' client APIs into the existing module, ensuring alignment with the server and maintaining backward compatibility

Issues Resolved

Related to #477

Testing the "include_unloaded_segments" parameter in the "stats" API resulted in an error indicating that the parameter is unrecognized (Implies generated "stats" API is correct)

get https://localhost:9200/_nodes/stats?include_unloaded_segments=true

{ "error": { "root_cause": [ { "type": "illegal_argument_exception", "reason": "request [/_nodes/stats] contains unrecognized parameter: [include_unloaded_segments]" } ], "type": "illegal_argument_exception", "reason": "request [/_nodes/stats] contains unrecognized parameter: [include_unloaded_segments]" }, "status": 400 }

Before giving your approval, kindly double-check.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #514 (60fb645) into main (70db37a) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files          83       83           
  Lines        7790     7790           
=======================================
  Hits         5521     5521           
  Misses       2269     2269           
Files Coverage Δ
opensearchpy/_async/client/nodes.py 63.15% <ø> (ø)
opensearchpy/client/nodes.py 63.15% <ø> (ø)