search

opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
359 stars 179 forks source link

fixes: #512 Wrong return type hint in async_scan #520

Closed bhavaniravi closed 1 year ago

bhavaniravi commented 1 year ago

Description

fixes: #512 Wrong return type hint in async_scan Verified the same with opensearch API

Issues Resolved

Closes #512

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #520 (559af66) into main (7d3c528) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 559af66 differs from pull request most recent head 1f1f97f. Consider uploading reports for the commit 1f1f97f to get more accurate results

@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files          83       83           
  Lines        7790     7790           
=======================================
  Hits         5521     5521           
  Misses       2269     2269
dblock commented 1 year ago

Is there a way we can test this? I'm thinking if there was a unit test that would exercise this API, then mypy would fail on it?