search

opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
350 stars 175 forks source link

Bumps urllib3 from >=1.21.1, <2 to >=1.26.9 (#518)(Backporting to 2.3 branch) #523

Closed saimedhi closed 1 year ago

saimedhi commented 1 year ago

Signed-off-by: saimedhi saimedhi@amazon.com (cherry picked from commit 781744c6b142193528b101eb05a758932cba00de)

Description

Bumps urllib3 from >=1.21.1, <2 to >=1.26.9

Issues Resolved

Closes #516

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #523 (e2ffb5b) into 2.3 (1216f66) will decrease coverage by 0.03%. Report is 1 commits behind head on 2.3. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.3     #523      +/-   ##
==========================================
- Coverage   70.92%   70.90%   -0.03%     
==========================================
  Files          81       81              
  Lines        7732     7732              
==========================================
- Hits         5484     5482       -2     
- Misses       2248     2250       +2
Files Coverage Δ
opensearchpy/_version.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

saimedhi commented 1 year ago

@VachaShah, can you please take a look.

saimedhi commented 1 year ago

Are we not removing python 3.4 support? Or is that in a different PR?

Also lets change the title of the PR to the correct versions for urllib3.

@VachaShah It's in another PR, and it's already merged. This PR title has the correct versions mentioned. 1.26.9 is the last version supporting Python 3.5. Please let me know if you have any more questions.