Closed dblock closed 11 months ago
Merging #547 (284a5fd) into main (fa8f3a7) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #547 +/- ##
==========================================
+ Coverage 70.63% 70.66% +0.02%
==========================================
Files 83 83
Lines 7857 7877 +20
==========================================
+ Hits 5550 5566 +16
- Misses 2307 2311 +4
Files | Coverage Δ | |
---|---|---|
opensearchpy/__init__.py | 92.85% <100.00%> (ø) |
|
opensearchpy/connection/http_urllib3.py | 82.00% <100.00%> (-4.03%) |
:arrow_down: |
opensearchpy/helpers/__init__.py | 100.00% <100.00%> (ø) |
|
opensearchpy/helpers/signer.py | 98.03% <100.00%> (+3.30%) |
:arrow_up: |
@harshavamsi would appreciate your CR since you did support for the requests connection class.
@VachaShah I wrote some more tests and addressed your comments. LMK if there's anything else needed for this one
Description
AWSV4SignerAuth
in favor ofRequestsAWSV4SignerAuth
Urllib3AWSV4SignerAuth
in the documentation since that transport is faster.Testing
AOS
AOSS
Issues Resolved
Closes https://github.com/opensearch-project/opensearch-py/issues/546
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.