opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
338 stars 170 forks source link

Expanded type coverage to benchmarks, samples and tests. #566

Closed dblock closed 10 months ago

dblock commented 10 months ago

Description

Expanded type coverage to benchmarks, samples and tests.

Issues Resolved

Closes https://github.com/opensearch-project/opensearch-py/issues/564.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 10 months ago

Codecov Report

Merging #566 (e9baa62) into main (dcb79cc) will decrease coverage by 0.01%. The diff coverage is 73.33%.

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
- Coverage   71.69%   71.69%   -0.01%     
==========================================
  Files          87       87              
  Lines        7875     7881       +6     
==========================================
+ Hits         5646     5650       +4     
- Misses       2229     2231       +2     
Files Coverage Δ
opensearchpy/__init__.py 100.00% <ø> (ø)
opensearchpy/_async/helpers/document.py 57.38% <100.00%> (ø)
opensearchpy/_async/helpers/index.py 60.80% <100.00%> (ø)
opensearchpy/_async/http_aiohttp.py 83.33% <100.00%> (ø)
opensearchpy/connection/async_connections.py 95.91% <100.00%> (+0.17%) :arrow_up:
opensearchpy/connection_pool.py 89.74% <100.00%> (ø)
opensearchpy/helpers/actions.py 44.22% <ø> (ø)
opensearchpy/helpers/asyncsigner.py 95.65% <100.00%> (ø)
opensearchpy/helpers/field.py 93.37% <100.00%> (ø)
opensearchpy/helpers/index.py 64.50% <100.00%> (ø)
... and 6 more
dblock commented 10 months ago

@saimedhi I think this is 🟢

dblock commented 10 months ago

@saimedhi good with you? (pls hit merge if yes)

dblock commented 10 months ago

I think @saimedhi is OOO, will merge (please add more comments and I can take of them later if needed), thanks @VachaShah for a CR.