search

opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
338 stars 170 forks source link

Fix for 592 #594

Closed dblock closed 10 months ago

dblock commented 10 months ago

Description

Go back to try/catch for requiring async code.

Issues Resolved

Closes #592.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4874437) 71.87% compared to head (75f6d05) 71.86%.

Files Patch % Lines
opensearchpy/__init__.py 80.00% 2 Missing :warning:
opensearchpy/connection/__init__.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #594 +/- ## ========================================== - Coverage 71.87% 71.86% -0.02% ========================================== Files 89 89 Lines 7922 7932 +10 ========================================== + Hits 5694 5700 +6 - Misses 2228 2232 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dblock commented 10 months ago

@harshavamsi You are absolutely right. Switch to using nox in CI.