search

opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
338 stars 170 forks source link

Update the GHA release workflow with trusted publisher enabled #614

Closed zelinh closed 10 months ago

zelinh commented 10 months ago

Description

Enable GHA release by adding trusted publisher. This workflow will be triggered when a tag is pushed to this repository. The workflow will built the product and publish to Pypi. The GitHub release will be created after publishing to Pypi with artifacts.tar.gz.

I will add this workflow as trusted publisher according to this. https://docs.pypi.org/trusted-publishers/adding-a-publisher/

Issues Resolved

Part of https://github.com/opensearch-project/opensearch-build-libraries/issues/222

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0cb345d) 71.98% compared to head (c7cd359) 71.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #614 +/- ## ======================================= Coverage 71.98% 71.98% ======================================= Files 89 89 Lines 7935 7935 ======================================= Hits 5712 5712 Misses 2223 2223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dblock commented 10 months ago

Btw, we noticed https://github.com/opensearch-project/opensearch-py/issues/609 related to publishing to pypi. Maybe you know how to fix it ...

zelinh commented 10 months ago

OIDC on Pypi side for trusted publisher is added.