Closed jayaddison closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6f26eb3
) 71.98% compared to head (6b876d3
) 71.98%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jayaddison, I think changelog entry is not needed.
I opened two more issues related to API generator, #619 and #618, if you have any interest @jayaddison :)
Thanks @saimedhi - I had pushed a commit with a changelog entry a few moments before seeing that you added a label to skip it. It was merged - I hope that's OK?
@dblock those issues do look interesting, thanks; I cannot offer any sense of when I might work on them yet, though.
Something that I notice about the utils/generate_api.py
script is that it could be difficult to easily confirm what version (git
commit ID) of the OpenSearch.openapi.json
spec file was used to produce the output. Has including a version/commit identifier, or referencing the spec file using a git submodule
been considered?
I would largely prefer a submodule for the exact reason you describe. Feel free to open a feature request or just do it (TM).
Description
This is a small followup to @samuelorji's cleanup in #615. It applies the same cleanup (removal of a redundant/default
coding
declaration ofutf-8
in source files) to thelicense_headers.py
check script itself.This pull request also removes that line from the list of
LINES_TO_KEEP
- lines of source code that aren't checked by the license check script - since it shouldn't appear anymore.Issues Resolved
613
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.