Assignment from no return

macohen commented 10 months ago

Description

enables assignment-from-no-return ~ updated to pass this by marking Facet.get_value_filter(self, filter_value: Any) -> Any as an abc.abstractmethod~ ~ implemented these missing methods in two subclasses to return None~
wondering if we would be better off not enforcing this, but I'm leaning towards enforcement

Issues Resolved

progress on #610

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6e58837) 72.13% compared to head (c2c9c22) 72.14%. Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #658 +/- ## ========================================== + Coverage 72.13% 72.14% +0.01% ========================================== Files 89 89 Lines 7945 7945 ========================================== + Hits 5731 5732 +1 + Misses 2214 2213 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

saimedhi commented 10 months ago

Few tests are failing. Please try to make them pass.

opensearch-project / opensearch-py