Added an automated api update bot for opensearch-py

opensearch-project / opensearch-py

Python Client for OpenSearch

https://opensearch.org/docs/latest/clients/python/

Apache License 2.0

338 stars 170 forks source link

Added an automated api update bot for opensearch-py #664

Closed saimedhi closed 7 months ago

saimedhi commented 8 months ago

Description

Added an automated api update bot for opensearch-py

Issues Resolved

Closes #619

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi saimedhi@amazon.com

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d905bef) 72.14% compared to head (53637ef) 72.14%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #664 +/- ## ======================================= Coverage 72.14% 72.14% ======================================= Files 89 89 Lines 7945 7945 ======================================= Hits 5732 5732 Misses 2213 2213 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

saimedhi commented 8 months ago

To install the opensearchpy-api-update-bot, the administrator must grant approval for the request.

Failing tests are related to issue #653

@VachaShah please take a look.

saimedhi commented 8 months ago

@VachaShah, shall we merge it? Is there any other way to test?

VachaShah commented 8 months ago

@VachaShah, shall we merge it? Is there any other way to test?

You can test it on your fork (remove the github app token step since that is related to the org). It should work without it on your fork and you can post here the PR that is created from this workflow.

saimedhi commented 8 months ago

@VachaShah, I followed workflow given in the issue #619

Workflow: https://github.com/slack-ruby/slack-ruby-client/blob/master/.github/workflows/update_api.yml

Example outcome PR: https://github.com/saimedhi/opensearch-py/pull/24 produced with this workflow.

saimedhi commented 8 months ago

@VachaShah, please take a look. This workflow is working in my main branch but opensearch-py tests are not running on the created PR. PR created: https://github.com/saimedhi/opensearch-py/pull/29

saimedhi commented 8 months ago

@VachaShah, please take a look. This workflow is working in my main branch but opensearch-py tests are not running on the created PR. PR created: saimedhi#29

On my fork all the tests are passing. (screenshots from workflows) Failing tests are related to #652

VachaShah commented 8 months ago

@VachaShah, please take a look. This workflow is working in my main branch but opensearch-py tests are not running on the created PR. PR created: saimedhi#29

On my fork all the tests are passing. (screenshots from workflows) Failing tests are related to #652

@saimedhi I think these tests are not appearing on your PR because the checks are running on the first commit but not on the second commit. Lets try one thing here: we can move the update changelog commit step to before creating the PR? So the PR would be created with both the commits.

saimedhi commented 8 months ago

@VachaShah, please take a look. This workflow is working in my main branch but opensearch-py tests are not running on the created PR. PR created: saimedhi#29

On my fork all the tests are passing. (screenshots from workflows) Failing tests are related to #652

@saimedhi I think these tests are not appearing on your PR because the checks are running on the first commit but not on the second commit. Lets try one thing here: we can move the update changelog commit step to before creating the PR? So the PR would be created with both the commits.

Made the changes as suggested. PR created: https://github.com/saimedhi/opensearch-py/pull/33

dblock commented 7 months ago

@VachaShah you good with this?