opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
338 stars 170 forks source link

fix: retry_on_conflict is int not bool #690

Closed pattrickrice closed 1 month ago

pattrickrice commented 6 months ago

Description

retry_on_conflict appears to be typed incorrectly in select locations. The documentation points to the value for this being an integer. https://opensearch.org/docs/1.0/opensearch/rest-api/document-apis/update-document/

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.14%. Comparing base (d36a882) to head (5e8e5c7). Report is 55 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #690 +/- ## ======================================= Coverage 72.14% 72.14% ======================================= Files 89 89 Lines 7945 7945 ======================================= Hits 5732 5732 Misses 2213 2213 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

saimedhi commented 6 months ago

Hello @pattrickrice,

Thank you for your contribution! Could you please address the failing tests? The DCO and CI are failing due to lint errors. Setting the default to 0 should resolve this issue.

dblock commented 1 month ago

I finished this in https://github.com/opensearch-project/opensearch-py/pull/795.