opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
338 stars 170 forks source link

Added guide for configuring ssl_assert_hostname #694

Closed saimedhi closed 6 months ago

saimedhi commented 6 months ago

Description

Added guide for configuring ssl_assert_hostname

Issues Resolved

Relevant to PR

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.14%. Comparing base (d36a882) to head (0005ecf). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #694 +/- ## ======================================= Coverage 72.14% 72.14% ======================================= Files 89 89 Lines 7945 7945 ======================================= Hits 5732 5732 Misses 2213 2213 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dblock commented 6 months ago

The existing doc says ssl_assert_hostname = False, should it be = None?

saimedhi commented 6 months ago

The existing doc says ssl_assert_hostname = False, should it be = None?

In the existing doc, comment says # hostname verification disabled. Therefore ssl_assert_hostname = False is correct.

dblock commented 6 months ago

Are integration test failures expected?

saimedhi commented 6 months ago

Are integration test failures expected?

Verified that failing tests aren't related to this PR; they're YAML tests. Currently working on fixing them.