Fixed YAML test runner for failing search/highlight/30_max_analyzed_offset[5] test

saimedhi commented 8 months ago

Description

Fixed YAML test runner for failing search/highlight/30_max_analyzed_offset[5] test in integration tests against an unreleased versions 2.x, main of OpenSearch.

Note: This test is failing in several released opensearch versions as well. To address the failing tests in those versions, I'll correct the skipped versions in the opensearch main branch. Skip version should be version: " - 2.12.99"

Issues Resolved

Additional context

This test case asserts

match: {hits.hits.0.highlight.field1.0: "The <em>quick</em> "}
Yaml test runner is considering it as match: {hits.hits.0.highlight.field1.0: "The <em>quick</em>"} without space at the end because of value.strip() here.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.14%. Comparing base (d36a882) to head (9050fc6).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #696 +/- ## ======================================= Coverage 72.14% 72.14% ======================================= Files 89 89 Lines 7945 7945 ======================================= Hits 5732 5732 Misses 2213 2213 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

saimedhi commented 8 months ago

Verified that this PR is not causing additional test failures.

dblock commented 8 months ago

Better. When it's a regex, ignore spaces, otherwise match.

opensearch-project / opensearch-py