opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
338 stars 170 forks source link

Introduced service time metrics to OpenSearch-Py client. #716

Closed saimedhi closed 5 months ago

saimedhi commented 5 months ago

Description

Introduced service time metrics to OpenSearch-Py client.

Issues Resolved

678

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 65.78947% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 71.91%. Comparing base (ba715b9) to head (5247b67).

:exclamation: Current head 5247b67 differs from pull request most recent head a625715. Consider uploading reports for the commit a625715 to get more accurate results

Files Patch % Lines
opensearchpy/metrics/metrics_events.py 48.48% 17 Missing :warning:
opensearchpy/metrics/metrics.py 76.19% 5 Missing :warning:
opensearchpy/connection/http_requests.py 66.66% 2 Missing :warning:
opensearchpy/connection/http_urllib3.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #716 +/- ## ========================================== - Coverage 71.95% 71.91% -0.05% ========================================== Files 91 94 +3 Lines 8001 8085 +84 ========================================== + Hits 5757 5814 +57 - Misses 2244 2271 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

saimedhi commented 5 months ago

The failing tests are not related to this PR but are caused by recent changes to the OpenSearch API Specification, which is now natively written in OpenAPI. The generator and developer guide will be fixed accordingly in an upcoming PR.

saimedhi commented 5 months ago

@VachaShah please take a look

saimedhi commented 5 months ago

Ready for review