search

opensearch-project / opensearch-py

Python Client for OpenSearch
https://opensearch.org/docs/latest/clients/python/
Apache License 2.0
338 stars 170 forks source link

[BUG] Events import failed after updating to v2.6 #756

Open julianogv opened 4 months ago

julianogv commented 4 months ago

What is the bug?

I have a project with a folder named events and after updating the opensearch-py from 2.5 to 2.6, where the service time metrics was added, I'm receiving the error below because python tries to import the Events from my project's home directory and not from the Events lib. As events is a common name for folders and it might cause some trouble with other people too, do you have any suggestion for fixing this issue without renaming my project's folder to another name?

 File "/home/[redacted]/venv/lib/python3.11/site-packages/opensearchpy/metrics/metrics_events.py", line 13, in <module>
    from events import Events
ImportError: cannot import name 'Events' from 'events'

How can one reproduce the bug?

Add a folder events to your project and them call from opensearchpy import OpenSearch

What is your host/environment?

python3.11 + ubuntu 20 + opensearch 2.6

dblock commented 4 months ago

Should it be importing from the lib? Is this something we can/need to change in the library? If you know how, please PR?

fnitsche commented 2 months ago

Yep, we are hitting this issue too. We have an events folder and get the same error when we try to update to 2.6

saimedhi commented 2 months ago

@fnitsche, @julianogv, would you be interested in contributing a fix for this issue? Thanks!