Closed dblock closed 1 month ago
Attention: Patch coverage is 57.03704%
with 116 lines
in your changes missing coverage. Please review.
Project coverage is 70.25%. Comparing base (
ba715b9
) to head (f7a7397
). Report is 45 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Maybe @saimedhi @VachaShah can review?
install_requires = [
'urllib3>=1.26.19,<1.27 ; python_version < "3.10"',
'urllib3>=1.26.19,!=2.2.0,<3 ; python_version >= "3.10"',
"requests>=2.32.0, <3.0.0",
"python-dateutil",
"certifi>=2024.07.04",
"Events",
]
- looks good to me.
- Going through the CVEs to confirm if below are right version bumps
install_requires = [ 'urllib3>=1.26.19,<1.27 ; python_version < "3.10"', 'urllib3>=1.26.19,!=2.2.0,<3 ; python_version >= "3.10"', "requests>=2.32.0, <3.0.0", "python-dateutil", "certifi>=2024.07.04", "Events", ]
'urllib3>=1.26.19,!=2.2.0,<3 ; python_version >= "3.10"',
here 2.2.1 should also be removed as per affected versions here https://github.com/urllib3/urllib3/security/advisories/GHSA-34jh-p97f-mpxf
'urllib3>=1.26.19,!=2.2.0,<3 ; python_version >= "3.10"',
here 2.2.1 should also be removed as per affected versions here GHSA-34jh-p97f-mpxf
Done.
Description
requests
,urllib3
andcertifi
is right, so please lmk if you think it's not.nox ...
tests withUnknown distribution option: 'test_suite'.
.Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.