Closed borisevich-a-v closed 1 month ago
Sorry, I cannot satisfy DCO due to my account settings. But PR is signed off correctly
Add a test please?
I am not sure what the issue with DCO is, why can’t it be fixed with your account?
Add a test please?
Sure, I'll add
I am not sure what the issue with DCO is, why can’t it be fixed with your account?
Hope it will not be a problem. I have two GitHub accounts due to job requirements. And for this one I have secondary email address for a while.
Added test and also fixed the same problem with ignore, if you don't mind
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.31%. Comparing base (
ba715b9
) to head (0e5bf2e
). Report is 58 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dblock Added tests, fixed AsyncTransport as well Tried to add code in the same code style, if there is any mistakes let me know
I am not sure what the issue with DCO is, why can’t it be fixed with your account?
Hope it will not be a problem. I have two GitHub accounts due to job requirements. And for this one I have secondary email address for a while.
I am not supposed to approve PRs without passing DCO :) Let's try to fix it.
You can configure the email address per repo. I do this routinely on a work computer for anything non-work.
git config user.name ...
git config user.email ...
Does this work?
Does this work?
The problem was with my emails. I have satisfied DCO :)
Description
Fixed bug https://github.com/opensearch-project/opensearch-py/issues/809
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.