opensearch-project / opensearch-rs

OpenSearch Rust Client
Apache License 2.0
63 stars 34 forks source link

add api_generated/rest_specs to .gitignore #195

Closed AbhinavGarg90 closed 1 year ago

AbhinavGarg90 commented 1 year ago

What/Why

What are you proposing?

Add files containted in api_generator/rest_specs to .gitignore

What users have asked for this feature?

What problems are you trying to solve?

These files never need to be pushed back to remote. Whenever the api is generated, these files will be too. Developers have to either delete the folder or remove the index manually to conveniently be able to push back to the repository.

What is the developer experience going to be?

It should be a simple addition of a line to .gitignore

Are there any security considerations?

None

Are there any breaking changes to the API

None

What is the user experience going to be?

May be inconvenient for somebody who is trying to use it as a package.

Are there breaking changes to the User Experience?

None

Why should it be built? Any reason not to?

Improved developer experience

Any remaining open questions?

Is this a change we are open to make?

AbhinavGarg90 commented 1 year ago

I realized that we cannot remove it, since a default api needs to be available.