search

opensearch-project / opensearch-rs

OpenSearch Rust Client
Apache License 2.0
59 stars 34 forks source link

Implement middleware types to allow intercepting client & request handling #232

Closed Xtansia closed 8 months ago

Xtansia commented 9 months ago

Description

Implement middleware types to allow intercepting client & request handling

Split from #132

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (360e88c) 74.07% compared to head (2d8d0e8) 73.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #232 +/- ## ========================================== - Coverage 74.07% 73.94% -0.13% ========================================== Files 403 407 +4 Lines 64138 64286 +148 ========================================== + Hits 47508 47536 +28 - Misses 16630 16750 +120 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-rs/pull/232/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/opensearch-project/opensearch-rs/pull/232/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `73.94% <ø> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Xtansia commented 9 months ago

@reta Have made changes regarding your comments

reta commented 9 months ago

@reta Have made changes regarding your comments

Thanks @Xtansia , I have briefly looked at it and overall looks pretty clean, I would love to have a bit more to go over the change but not reasons to hold it off if you need to, thank you

Xtansia commented 9 months ago

@reta Have made changes regarding your comments

Thanks @Xtansia , I have briefly looked at it and overall looks pretty clean, I would love to have a bit more to go over the change but not reasons to hold it off if you need to, thank you

No rush on getting it merged, will need to go in a major release anyway due to the prior error type changes. Definitely open to feedback, don't want to do it half-baked. So take as much time as you like to go over it