opensearch-project / opensearch-ruby

Ruby Client for OpenSearch
Apache License 2.0
93 stars 47 forks source link

Switch ruby version to 3.1.2 on release pipeline #241

Closed gaiksaya closed 5 months ago

gaiksaya commented 5 months ago

Description

Switch ruby version to 3.1.2 on release pipeline. There is no need to switch the docker image as, it is already pointing to most recent one.

Issues Resolved

closes https://github.com/opensearch-project/opensearch-build/issues/4624

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Earlopain commented 5 months ago

@gaiksaya just to make sure, in https://github.com/opensearch-project/logstash-output-opensearch/pull/191 you did add a override for the docker image. That is not needed?

gaiksaya commented 5 months ago

Hi @Earlopain

So if you check the overview here: https://hub.docker.com/r/opensearchstaging/ci-runner

Tags with 2 digits (such as v2.1) are backups of the previous iteration, and the major tag (such as v2) is always pointing to the latest iteration.

Since we are using v4, it is already up to date: https://github.com/opensearch-project/opensearch-build-libraries/blob/6.4.4/vars/standardReleasePipelineWithGenericTrigger.groovy#L31

Earlopain commented 5 months ago

Ah, I see (:. Thank you for that showing me