opensearch-project / opensearch-sdk-java

OpenSearch SDK to build and run extensions
Apache License 2.0
28 stars 58 forks source link

Determine whether to store threadPool in BaseExtension/SDK or initialize it in the extension itself. #183

Open ryanbogan opened 1 year ago

ryanbogan commented 1 year ago

Currently, threadPool is an instance variable in BaseExtension and is initialized within the SDK. This issue will determine whether to continue with the current practice or initialize it in the actual extension.

dbwiddis commented 1 year ago

The ExtensionRunner / BaseExtension / Extension are all the same JVM and same threadpool.

If we already have it, it should be available for anyone to use.

dbwiddis commented 1 year ago

I've been thinking about this in the context of the various places we will run Extensions. It makes sense to just have a thread pool object on the ExtensionsRunner which will be accessible from extensions (via base extension setter as of #244).