opensearch-project / opensearch-sdk-java

OpenSearch SDK to build and run extensions
Apache License 2.0
28 stars 59 forks source link

Add handlers for read, update, and delete to CREATE_YOUR_FIRST_EXTENSION doc #864

Closed dbwiddis closed 1 year ago

dbwiddis commented 1 year ago

Description

Updates CREATE_YOUR_FIRST_EXTENSION with the RUD part of CRUD (and a better C example). Also fixes the internal links broken in earlier reviews.

Please merge #827 (and then rebase this PR) prior to merging this PR, as this builds on updates from that PR to Named Routes.

Reference project implementing this, with the code tested: https://github.com/dbwiddis/CRUDExtension

Issues Resolved

Part of #836 (Documentation)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dbwiddis commented 1 year ago

A couple of comments, mainly making the document more user-centric. Thanks!

Thanks! Can you tell I spent way too long in academia where "we" is the standard? :)

kolchfa-aws commented 1 year ago

Yes, "we" when we're doing an experiment, and "you" when you want the user to do something :)

owaiskazi19 commented 1 year ago

@kolchfa-aws @natebower looks good to you before we merge the changes in?

kolchfa-aws commented 1 year ago

LGTM 😄