[Refactor] Introduce flint-commons for models and interfaces

opensearch-project / opensearch-spark

Spark Accelerator framework ; It enables secondary indices to remote data stores.

Apache License 2.0

12 stars 18 forks source link

[Refactor] Introduce flint-commons for models and interfaces #373

Closed noCharger closed 2 weeks ago

noCharger commented 2 weeks ago

Description

[Refactor] Introduce flint-data for models and interfaces
- Full details https://github.com/opensearch-project/opensearch-spark/issues/376
- This PR will only move FlintCommand and FlintInstance
- Other interfaces will be updated continously: For example, SessionManager and CommandLifecycleManager will go next, then FlintMetadataLogEntry, FlintMetadataLogService, etc
A new jar will be assembled flint-data-assembly-0.5.0-SNAPSHOT.jar

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dai-chen commented 2 weeks ago

Just read issue https://github.com/opensearch-project/opensearch-spark/issues/376 for context. IMHO, flint-data is confusing and not sure what we plan to put into this module in future. Any better name? At the moment, the module is more like Flint session model?

noCharger commented 2 weeks ago

Just read issue #376 for context. IMHO, flint-data is confusing and not sure what we plan to put into this module in future. Any better name? At the moment, the module is more like Flint session model?

What is the rationale behind naming flintData? It seems to suggest to have all the related model classes, but it does have behavior classes.

@dai-chen @vamsi-amazon The primary goal is to provide a shared library that allows for easier extension. So maybe flint-common or flint-utils, any suggestions?

vamsi-amazon commented 2 weeks ago

Just read issue #376 for context. IMHO, flint-data is confusing and not sure what we plan to put into this module in future. Any better name? At the moment, the module is more like Flint session model?

What is the rationale behind naming flintData? It seems to suggest to have all the related model classes, but it does have behavior classes.

@dai-chen @vamsi-amazon The primary goal is to provide a shared library that allows for easier extension. So maybe flint-common or flint-utils, any suggestions?

flint-commons can be a good name....but we need to define what the responsibility of the module.

noCharger commented 2 weeks ago

Just read issue #376 for context. IMHO, flint-data is confusing and not sure what we plan to put into this module in future. Any better name? At the moment, the module is more like Flint session model?

What is the rationale behind naming flintData? It seems to suggest to have all the related model classes, but it does have behavior classes.

@dai-chen @vamsi-amazon The primary goal is to provide a shared library that allows for easier extension. So maybe flint-common or flint-utils, any suggestions?

flint-commons can be a good name....but we need to define what the responsibility of the module.

Thanks, update the responsibility in readme