Open noCharger opened 2 months ago
For glue type data source, Current create MV logic doesn't validate the existence of Database nor Table of glue data catalog.
CREATE MATERIALIZED VIEW dummyDatasource.dummyDB.dummyTable.dummyMV **** CREATE MATERIALIZED VIEW dummyDB.dummyTable.dummyMV ****
Both will create OpenSearch index with nameflint_dummyDatasource_dummyDB_dummyTable_dummyMV
flint_dummyDatasource_dummyDB_dummyTable_dummyMV
CREATE MATERIALIZED VIEW dummyMV ****
This will create OpenSearch index with nameflint_dummyDatasource_default_dummyMV
flint_dummyDatasource_default_dummyMV
CREATE MATERIALIZED VIEW dummyDatasource.dummyMV ****
This will create OpenSearch index with nameflint_dummyDatasource__dummyMV
flint_dummyDatasource__dummyMV
CREATE MATERIALIZED VIEW dummyTable.dummyMV **** CREATE MATERIALIZED VIEW dummyDatasource.dummyTable.dummyMV ****
Both will create OpenSearch index with name flint_dummyDatasource_dummyTable_dummyMV
flint_dummyDatasource_dummyTable_dummyMV
CREATE MATERIALIZED VIEW dummyDB.dummyMV **** CREATE MATERIALIZED VIEW dummyDatasource.dummyDB.dummyMV ****
Both will create OpenSearch index with name flint_dummyDatasource_dummyDB_dummyMV
flint_dummyDatasource_dummyDB_dummyMV
Open to discuss: What's the user experience can be consolidated? Should the glue resources being validated before actually create the flint index?
One option to mitigate this issue: Add index name to FlintMetadataLogEntry, to decouple the index naming logic from recover index itself.
Related: https://github.com/opensearch-project/sql/issues/2908
For glue type data source, Current create MV logic doesn't validate the existence of Database nor Table of glue data catalog.
Both will create OpenSearch index with name
flint_dummyDatasource_dummyDB_dummyTable_dummyMV
This will create OpenSearch index with name
flint_dummyDatasource_default_dummyMV
This will create OpenSearch index with name
flint_dummyDatasource__dummyMV
Both will create OpenSearch index with name
flint_dummyDatasource_dummyTable_dummyMV
Both will create OpenSearch index with name
flint_dummyDatasource_dummyDB_dummyMV
Open to discuss: What's the user experience can be consolidated? Should the glue resources being validated before actually create the flint index?