[FEATURE]Refactor Catalyst visitor to match AST Builder composition - Githubissues

opensearch-project / opensearch-spark

Spark Accelerator framework ; It enables secondary indices to remote data stores.

Apache License 2.0

22 stars 33 forks source link

[FEATURE]Refactor Catalyst visitor to match AST Builder composition #851

Closed YANG-DB closed 3 weeks ago

YANG-DB commented 3 weeks ago

Is your feature request related to a problem? We would like to refactor the CatalystQueryPlanVisitor and separate it into two distinct visitors:

Plan Visitor ( which extends AbstractNodeVisitor<LogicalPlan, CatalystPlanContext> )
Expression Visitor (which extends AbstractNodeVisitor<Expression, CatalystPlanContext>)

This would match the existing PPL AST visitors composition:

AstBuilder ( which extends OpenSearchPPLParserBaseVisitor)
AstExpressionBuilder ( which extends OpenSearchPPLParserBaseVisitor )

In addition unify the ppl utils classes to match one of the following naming:

*Transformer - transforms PPL (logical) expressions into Spark (logical) expressions
*Utils - utility class

Do you have any additional context? Add any other context or screenshots about the feature request here.