opensearch-project / opentelemetry-demo

This repository contains the OpenSearch adaptation for the OpenTelemetry Astronomy Shop, a microservice-based distributed system intended to illustrate the implementation of OpenTelemetry in a near real-world environment.

https://opentelemetry.io/docs/demo/

Apache License 2.0

15 stars 16 forks source link

Update docker for default admin creds update #114

Closed derek-ho closed 7 months ago

derek-ho commented 8 months ago

Changes

Passes in an initial admin password via env variable, implemented in security plugin main and 2.x lines, for 2.12.0 release.

Merge Requirements

For new features contributions please make sure you have completed the following essential items:

[ ] CHANGELOG.md updated to document new feature additions
[ ] Appropriate documentation updates in the docs
[ ] Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure which docs need to be changed ping the @open-telemetry/demo-approvers.

derek-ho commented 8 months ago

@YANG-DB can you help me understand what other changes this repo needs? It doesn't seem to follow the branching strategy of main/2.x - so do we need to handle logic to determine whether to use the default admin password, or the env variable password in the ES_PASSWORD field? Any other places you see that would need changes? Thanks!

derek-ho commented 8 months ago

https://github.com/opensearch-project/security/issues/3624

YANG-DB commented 8 months ago

@derek-ho please use the .env for all the password’s place holders

github-actions[bot] commented 8 months ago

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] commented 7 months ago

Closed as inactive. Feel free to reopen if this PR is still being worked on.

DarshitChanpura commented 7 months ago

@derek-ho please use the .env for all the password’s place holders

@derek-ho Could you please address this comment.

derek-ho commented 7 months ago

Marking this as draft until variable OPENSEARCH_VERSION changes to >= 2.12.0.

derek-ho commented 7 months ago

Done. @YANG-DB can you take another look? I also changed the image from staging to the actual released docker images, similar to the dashboards image (which is not using staging).

derek-ho commented 7 months ago

@YANG-DB can you double check again and we can merge if everything looks good?

github-actions[bot] commented 7 months ago

This PR was marked stale due to lack of activity. It will be closed in 7 days.

DarshitChanpura commented 7 months ago

@YANG-DB @pjfitzgibbons @ps48 @kavithacm @joshuali925 @dai-chen @rupal-bq @mengweieric @vamsi-amazon @Swiddis Could we get this reviewed as we are targeting 2.12 for this change?

DarshitChanpura commented 7 months ago

@YANG-DB @pjfitzgibbons @ps48 @kavithacm @joshuali925 @dai-chen @rupal-bq @mengweieric @vamsi-amazon @Swiddis Still waiting for reviews. Could we get this reviewed as we are targeting 2.12 for this change?